[SYCL][Native CPU] Avoid dangling references. #20145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multiple places, we take a reference to an element in LoopMasks and expect that reference to remain valid. LoopMasks is a DenseMap which does not promise that references to existing elements remain valid as new elements are inserted. We pre-populate LoopMasks to try and avoid this becoming a problem, but we were pre-populating it only with top-level loops, when sub-loops may also cause references to become invalid. Adjust the pre-population to take all loops into account.
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
approved these changes
Sep 22, 2025
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers This is ready to be merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple places, we take a reference to an element in LoopMasks and expect that reference to remain valid. LoopMasks is a DenseMap which does not promise that references to existing elements remain valid as new elements are inserted. We pre-populate LoopMasks to try and avoid this becoming a problem, but we were pre-populating it only with top-level loops, when sub-loops may also cause references to become invalid. Adjust the pre-population to take all loops into account.